Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'free up disk space more quickly' FAQ item #19087

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-11638

Copy link

github-actions bot commented Nov 1, 2024

Files changed:

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 4d42c4d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6758ac8aa7ec2600081d649d

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 4d42c4d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6758ac8a62b6d70008a10cfd

Copy link

netlify bot commented Nov 1, 2024

Netlify Preview

Name Link
🔨 Latest commit 4d42c4d
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6758ac8a1447e30008ba4cfd
😎 Deploy Preview https://deploy-preview-19087--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this so quickly!

src/current/_includes/v23.1/storage/free-up-disk-space.md Outdated Show resolved Hide resolved
src/current/_includes/v23.2/storage/free-up-disk-space.md Outdated Show resolved Hide resolved
src/current/_includes/v24.1/storage/free-up-disk-space.md Outdated Show resolved Hide resolved
src/current/_includes/v24.2/storage/free-up-disk-space.md Outdated Show resolved Hide resolved
src/current/_includes/v24.3/storage/free-up-disk-space.md Outdated Show resolved Hide resolved
src/current/v23.1/operational-faqs.md Outdated Show resolved Hide resolved
@rmloveland rmloveland requested a review from ajstorm December 5, 2024 20:43
Copy link

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting to this.

@rmloveland rmloveland requested a review from taroface December 10, 2024 21:03
@rmloveland
Copy link
Contributor Author

@taroface the changes across all files are the same as you can see; if you have comments on one version i will port to all others - thanks!

Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; one suggestion

@@ -81,9 +81,13 @@ When MVCC garbage is deleted by garbage collection, the data is still not yet ph

{% include {{page.version.version}}/storage/free-up-disk-space.md %}

## How can I free up disk space quickly?
## How can I free up disk space when dropping a table?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## How can I free up disk space when dropping a table?
## How can I free up disk space that was used by a dropped table?

@@ -1 +1 @@
For instructions on how to free up disk space as quickly as possible after deleting data, see [How can I free up disk space quickly?]({% link {{ page.version.version }}/operational-faqs.md %}#how-can-i-free-up-disk-space-quickly)
For instructions on how to free up disk space as quickly as possible after dropping a table, see [How can I free up disk space that was used by a dropped table?]({% link {{ page.version.version }}/operational-faqs.md %}#how-can-i-free-up-disk-space-when-dropping-a-table)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For instructions on how to free up disk space as quickly as possible after dropping a table, see [How can I free up disk space that was used by a dropped table?]({% link {{ page.version.version }}/operational-faqs.md %}#how-can-i-free-up-disk-space-when-dropping-a-table)
For instructions on how to free up disk space as quickly as possible after dropping a table, see [How can I free up disk space that was used by a dropped table?]({% link {{ page.version.version }}/operational-faqs.md %}#how-can-i-free-up-disk-space-that-was-used-by-a-dropped-table)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants